Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stream definitions for new coupler history file format #228

Merged
merged 4 commits into from
May 9, 2023

Conversation

olyson
Copy link
Contributor

@olyson olyson commented May 2, 2023

Description of changes

Modify stream_definition_datm.xml to generate a streams file (datm.streams.xml) with the new coupler history file format.

Specific notes

Changes to accommodate new coupler history file names.
Change offset for solar stream from 2700 to -900 to accommodate changes due to time stamps.
These changes work in conjunction with CDEPS PR #224 and CDEPS PR #222 .
Note that I did not change the file names for ndep, or remove that stream. Presumably, that stream will be removed at some point due to CAM now always sending ndep.

Contributors other than yourself, if any: @billsacks

CDEPS Issues Fixed (include github issue #): N/A

Are there dependencies on other component PRs (if so list): No

Are changes expected to change answers (bfb, different to roundoff, more substantial): Yes, in coupler history mode.

Any User Interface Changes (namelist or namelist defaults changes): No

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): I have conducted a pair of cases, an F-case to generate coupler history files, and an I-case to read those files, using the new file name convention, and compared the forcing output variables from clm history files between the two cases. @billsacks and I reviewed these differences and found them to be acceptable.

@billsacks has agree to review these changes and perform more standard testing.

Hashes used for testing: N/A

@billsacks billsacks self-requested a review May 4, 2023 22:06
@billsacks billsacks self-assigned this May 4, 2023
Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thanks a lot, @olyson ! I don't see any testing that exercises cplhist mode other than a test in CTSM's aux_clm, which we'll need to update (I'll open an issue for that) -- so I don't think there's any more testing needed right now beyond what you've already done.

I do think we'll need to follow up on the ndep stream, since I think we'll want to have datm read from the cplhist file for ndep, though that can be done in a follow-up PR, since right now CTSM wouldn't be listening to the ndep from datm anyway.

@billsacks billsacks merged commit af2a809 into ESCOMP:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants