-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Remove Poetry, add Mixup, rework metrics, & improve code quality #70
Conversation
✨ add beta nll, a modified GaussianNLL
- 🔨 Move plotting utils to Calibration Error wrapper plot method
🐛 ``use_cv`` argument is not initialized for regression datasets -> ``cli_main()`` checks whether ``use_cv`` exists. 🔨 add a new documentation template for classes to not display inherited members
✨ Sparsification metric and plot methods for Calibration Error
🐛 Fix Monte-Carlo Dropout
|
||
self.num_estimators = num_estimators | ||
|
||
def feats_forward(self, x: Tensor) -> Tensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not seem to be right now
It could become helpful in the future if we want to test methods that work on the features, but I can remove it if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I see, we can leave it here then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Merging this right away :)
Postponed to another PR