Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Remove Poetry, add Mixup, rework metrics, & improve code quality #70

Merged
merged 111 commits into from
Dec 15, 2023
Merged

Conversation

o-laurent
Copy link
Contributor

@o-laurent o-laurent commented Nov 4, 2023

Postponed to another PR

  • [-] Implement calibration for ensemble classification
  • [-] Implement mixup for ensemble classification

qbouniot and others added 30 commits October 10, 2023 16:35
✨ add beta nll, a modified GaussianNLL
- 🔨 Move plotting utils to Calibration Error wrapper plot method
@o-laurent o-laurent added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 9, 2023
@o-laurent o-laurent added the bug Something isn't working label Dec 14, 2023
@o-laurent o-laurent marked this pull request as ready for review December 14, 2023 17:57

self.num_estimators = num_estimators

def feats_forward(self, x: Tensor) -> Tensor:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not seem to be right now
It could become helpful in the future if we want to test methods that work on the features, but I can remove it if you prefer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see, we can leave it here then.

Copy link
Contributor

@alafage alafage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merging this right away :)

@alafage alafage merged commit 0068ab5 into main Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 issue concerning the interaction of MC-Dropout and the other methods
4 participants