Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chicoma-cpu gnu and nvidia builds #6705

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Oct 22, 2024

Following the recent DST, this merge updates the module files and environment variables on Chicoma-CPU. We note that these updates work well for gnu and nvidia compilers but not yet for intel, which we are continuing to work on. A separate update will be needed to address Chicoma-GPU as well.

An environment variable has also been added to the MPAS standalone framework to accommodate overriding the library path for standard c++ on Chicoma.

See E3SM-Ocean-Discussion#112 for relevant discussion

[BFB] for all E3SM testing

@xylar
Copy link
Contributor Author

xylar commented Oct 22, 2024

I have successfully run:

SMS_D.TL319_oQU240wLI_ais8to30.MPAS_LISIO_JRA1p5.chicoma-cpu_gnu
SMS_D.TL319_oQU240wLI_ais8to30.MPAS_LISIO_JRA1p5.chicoma-cpu_nvidia

@mahf708
Copy link
Contributor

mahf708 commented Oct 22, 2024

Note gh/ci erros are fixable by #6686 (cc @rljacob)

@xylar
Copy link
Contributor Author

xylar commented Oct 22, 2024

I'll rebase once that goes in.

Comment on lines -399 to +403
"LDFLAGS_OPT = -O3 -m64" \
"LDFLAGS_OPT = -O3 -m64 $(GNU_CRAY_LDFLAGS)" \
"FFLAGS_DEBUG = -g -m64 -ffree-line-length-none -fconvert=big-endian -ffree-form -fbounds-check -fbacktrace -ffpe-trap=invalid,zero,overflow -ffpe-summary=none $${EXTRA_FFLAGS}" \
"CFLAGS_DEBUG = -g -m64" \
"CXXFLAGS_DEBUG = -g -m64" \
"LDFLAGS_DEBUG = -g -m64" \
"LDFLAGS_DEBUG = -g -m64 $(GNU_CRAY_LDFLAGS)" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewhoffman and @mark-petersen, this is what I want your review on. If you want to look at other changes or run tests, that would be appreciated but it's up to you.

Copy link
Contributor

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar , this solution for Chicoma looks good and seems reasonable given the current constraints. Thanks for sorting through this issue.

Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @xylar! I used the head of compass and tested this branch with gnu, both debug and optimized. It passes all tests for the nightly test suite for MPAS-Ocean standalone.

I also tested E3SM on this branch with

cd cime/scripts
./create_test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-cpu_gnu \
  -p t24_coastal_ocean --walltime 00:30:00

and it passes all steps.

@xylar
Copy link
Contributor Author

xylar commented Oct 23, 2024

I used the head of compass and tested this branch with gnu, both debug and optimized.

Thanks for testing, but how did that work? I'm working on Compass support in MPAS-Dev/compass#865 but I wouldn't have expected anyone to be able to build standalone MPAS-Ocean or create a working Compass enviornment on Chicoma until that goes in. And that requires a mache update as well.

@xylar xylar force-pushed the machine/update-chicoma-modules branch from c34336e to 0cb78ea Compare October 24, 2024 01:52
@jonbob jonbob added the BFB PR leaves answers BFB label Oct 24, 2024
jonbob added a commit that referenced this pull request Oct 24, 2024
Update chicoma-cpu gnu and nvidia builds

Following the recent DST, this merge updates the module files and
environment variables on LANL machine Chicoma-CPU. We note that these
updates work well for gnu and nvidia compilers but not yet for intel,
which we are continuing to work on. A separate update will be needed to
address Chicoma-GPU as well.

An environment variable has also been added to the MPAS standalone
framework to accommodate overriding the library path for standard c++
on Chicoma.

[BFB] for all E3SM testing
@jonbob
Copy link
Contributor

jonbob commented Oct 24, 2024

Passes:

  • ERP_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-pioroot1

and verified tests build and run on chicoma-cpu using gnu and nvidia

Merged to next

@jonbob jonbob merged commit 1442143 into E3SM-Project:master Oct 25, 2024
9 checks passed
@jonbob
Copy link
Contributor

jonbob commented Oct 25, 2024

merged to master

@xylar xylar deleted the machine/update-chicoma-modules branch October 25, 2024 20:47
@xylar
Copy link
Contributor Author

xylar commented Oct 25, 2024

Thanks @jonbob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants