Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup compiler warnings #3656

Merged
merged 3 commits into from
Jun 24, 2020
Merged

Cleanup compiler warnings #3656

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdd6cc3
Remove Intel compiler warnings
amametjanov Jun 19, 2020
0610b11
Cleanup IBM compiler warnings
amametjanov Jun 19, 2020
7c04964
Cleanup GNU compiler warnings
amametjanov Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion components/cam/src/chemistry/mozart/wei96.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,7 @@ INTEGER FUNCTION JULDAY(MM,ID,IYYY)
!-----------------------------------------------------------------------
!
use shr_kind_mod, only: r8 => shr_kind_r8
use cam_abortutils, only : endrun
implicit none
!
!------------------------------Arguments--------------------------------
Expand All @@ -926,7 +927,9 @@ INTEGER FUNCTION JULDAY(MM,ID,IYYY)
!
!-----------------------------------------------------------------------
!
IF (IYYY.EQ.0) PAUSE 'There is no Year Zero.'
IF (IYYY.EQ.0) THEN
call endrun('There is no Year Zero.')
ENDIF
Comment on lines -929 to +932
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/lcrc/group/acme/azamat/repos/E3SM-tests/components/cam/src/chemistry/mozart/wei96.F90:929:51:

       IF (IYYY.EQ.0) PAUSE 'There is no Year Zero.'
                                                   1
Warning: Deleted feature: PAUSE statement at (1)

IF (IYYY.LT.0) IYYY=IYYY+1
IF (MM.GT.2) THEN
JY=IYYY
Expand Down
6 changes: 3 additions & 3 deletions components/cice/src/mpi/ice_boundary.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2925,7 +2925,7 @@ subroutine ice_HaloUpdate3DR8(array, halo, &
ioffset, joffset, &! address shifts for tripole
isign ! sign factor for tripole grids

integer (int_kind), dimension(:), allocatable, save :: &
integer (int_kind), dimension(:), allocatable :: &
sndRequest, &! MPI request ids
rcvRequest ! MPI request ids
Comment on lines -2928 to 2930
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/lcrc/group/acme/azamat/repos/E3SM-tests/components/cice/src/mpi/ice_boundary.F90:2958:22:

       bufSend, bufRecv            ! 3d send,recv buffers
                      1
Warning: Legacy Extension: Duplicate SAVE attribute specified at (1)
/lcrc/group/acme/azamat/repos/E3SM-tests/components/cice/src/mpi/ice_boundary.F90:2958:13:

       bufSend, bufRecv            ! 3d send,recv buffers
             1
Warning: Legacy Extension: Duplicate SAVE attribute specified at (1)
/lcrc/group/acme/azamat/repos/E3SM-tests/components/cice/src/mpi/ice_boundary.F90:2961:16:

       bufTripole                  ! 3d tripole buffer
                1
Warning: Legacy Extension: Duplicate SAVE attribute specified at (1)
/lcrc/group/acme/azamat/repos/E3SM-tests/components/cice/src/mpi/ice_boundary.F90:2930:16:

       rcvRequest        ! MPI request ids
                1
Warning: Legacy Extension: Duplicate SAVE attribute specified at (1)
/lcrc/group/acme/azamat/repos/E3SM-tests/components/cice/src/mpi/ice_boundary.F90:2929:16:

       sndRequest,      &! MPI request ids
                1
Warning: Legacy Extension: Duplicate SAVE attribute specified at (1)


Expand Down Expand Up @@ -2954,10 +2954,10 @@ subroutine ice_HaloUpdate3DR8(array, halo, &
logical (log_kind) :: &
do_allocate ! flag used to control alloc of 3D buffers
#else
real (dbl_kind), dimension(:,:), allocatable, save :: &
real (dbl_kind), dimension(:,:), allocatable :: &
bufSend, bufRecv ! 3d send,recv buffers

real (dbl_kind), dimension(:,:,:), allocatable, save :: &
real (dbl_kind), dimension(:,:,:), allocatable :: &
bufTripole ! 3d tripole buffer
#endif

Expand Down
4 changes: 2 additions & 2 deletions components/cice/src/source/ice_forcing.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3248,12 +3248,12 @@ subroutine ocn_data_ncar_init
!
! 1 sst------temperature---------------------------(C) \\
! 2 sss------salinity------------------------------(ppt) \\
! 3 hbl------depth---------------------------------(m) \\
! 3 hbl------depth---------------------------------(m) \\
! 4 u--------surface u current---------------------(m/s) \\
! 5 v--------surface v current---------------------(m/s) \\
! 6 dhdx-----surface tilt x direction--------------(m/m) \\
! 7 dhdy-----surface tilt y direction--------------(m/m) \\
! 8 qdp------ocean sub-mixed layer heat flux-------(W/m2)\\
! 8 qdp------ocean sub-mixed layer heat flux-------(W/m2)\\
Comment on lines -3251 to +3256
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/lcrc/group/acme/azamat/repos/E3SM-tests/components/cice/src/source/ice_forcing.F90:3251:60:

 ! 3  hbl------depth---------------------------------(m)   \\

Warning: backslash and newline separated by space
/lcrc/group/acme/azamat/repos/E3SM-tests/components/cice/src/source/ice_forcing.F90:3256:60:

 ! 8  qdp------ocean sub-mixed layer heat flux-------(W/m2)\\

Warning: backslash and newline separated by space

!
! Fields 4, 5, 6, 7 are on the U-grid; 1, 2, 3, and 8 are
! on the T-grid.
Expand Down
2 changes: 0 additions & 2 deletions components/clm/src/biogeophys/WaterBudgetMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ module WaterBudgetMod
real(r8) :: budg_stateL(s_size, p_size)
real(r8), public :: budg_stateG(s_size, p_size)

logical,save :: first_time = .true.

Comment on lines -108 to -109
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/lcrc/group/acme/azamat/repos/E3SM-tests/components/clm/src/biogeophys/WaterBudgetMod.F90:108:28:

   logical,save :: first_time = .true.
                            1
Warning: Legacy Extension: Duplicate SAVE attribute specified at (1)

This var isn't used anywhere.

!----- formats -----
character(*),parameter :: FA0= "(' ',12x,(3x,a10,2x),' | ',(3x,a10,2x))"
character(*),parameter :: FF = "(' ',a12,f15.8,' | ',f18.2)"
Expand Down