Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A sensible refactoring #9

Open
abrudz opened this issue Jul 15, 2021 · 0 comments
Open

A sensible refactoring #9

abrudz opened this issue Jul 15, 2021 · 0 comments
Assignees
@rikedyp
Labels
enhancement New feature or request

Comments

@abrudz
Copy link
Member

abrudz commented Jul 15, 2021

There should probably be 3 js files (or 1 big one)
tryapl.js - deals with handling Jarvis & the fake session (basically rightPane stuff)
and the workspace upload/download stuff
jupyter.js - deals with loading, rendering notebooks
front.js - deals with split.js, has the window.onload function (which calls 1 function each in tryapl and jupyter for their needs), deals with the tabs and leftPane content (except for Jupyter), deals with split panes/dark mode localStorage

by no means urgent, just if we're bored one day
@abrudz abrudz added the enhancement New feature or request label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rikedyp rikedyp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rikedyp @abrudz