fix: Use locking when creating new keypairs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an advisory lock when creating a new keypair to prevent creating multiple keypairs for the same validity period. References #10
| LOCK_NAME = 'keypairs:rotate' | ||
|
|
||
| def rotate_keys_with_lock! | ||
| with_advisory_lock(LOCK_NAME) do |
There was a problem hiding this comment.
Hmm, Isn't this a bit overkill? How does this relate with the pessimistic locking like https://api.rubyonrails.org/classes/ActiveRecord/Locking/Pessimistic.html
There was a problem hiding this comment.
I agree with you that a solution like pessimistic or optimistic locking would be easier. However, we don't always have a clear idea which record to use for locking. For example, when we don't have any keypairs yet we don't have any records which we can lock. It's also not clear on which record we should lock, especially when there are multiple keypairs for the same time period, as there would be when migrating from a previous version of the gem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an advisory lock when creating a new keypair to prevent
creating multiple keypairs for the same validity period.
Closes #10