Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with hs_deals_raw() #103

Open
jonmcalder opened this issue Feb 27, 2020 · 2 comments
Open

Problems with hs_deals_raw() #103

jonmcalder opened this issue Feb 27, 2020 · 2 comments

Comments

@jonmcalder
Copy link
Contributor

(1) Doesn't respect the value of the max_properties argument
(this was obviously just overlooked and should be easy to remedy)

(2) In certain cases the hubspot API doesn't necessarily return the properties you request but throws in a whole lot of extra properties like some sort of packaged deal...

Options to deal with (2):

  1. Leave all the properties to be returned
  2. Drop the properties and notify
  3. Make extra property dropping toggleable
@stephlocke
Copy link
Collaborator

max_properties limits how many we request not how many we receive 😬

@jonmcalder
Copy link
Contributor Author

As things stand currently max_properties is actually not utilised anywhere in the source code of the function. It should at the very least restrict the number of properties requested. But nevertheless I do receive your point 😉

@stephlocke stephlocke mentioned this issue Feb 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonmcalder @stephlocke