Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with rubocop-gradual? #17

Open
pboling opened this issue Sep 20, 2023 · 2 comments
Open

Use with rubocop-gradual? #17

pboling opened this issue Sep 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@pboling
Copy link

pboling commented Sep 20, 2023

The rubocop-todo.yml pattern has a number of problems that make it less than ideal.

rubocop-gradual solves the problems inherent with rubocop-todo.yml, primarily, by using a lockfile, similar to bundler.

See: https://github.com/skryukov/rubocop-gradual

Because it discards with the entire concept of rubocop-todo.yml, replacing it with something better, would a project using rubocop_gradual would be unable to use rubocop_director?

@DmitryTsepelev
Copy link
Owner

Hey @pboling! I think that's right unless someone adds an adapter 🙂 The only place it's used is https://github.com/DmitryTsepelev/rubocop_director/blob/master/lib/rubocop_director/rubocop_stats.rb where we grab stats (and one another place where we make a copy, but that might be not needed).

So the plan would be:

  1. add a config option/just detect that gradual is in the bundle
  2. use a different stats fetcher
  3. profit

@DmitryTsepelev DmitryTsepelev added the enhancement New feature or request label Sep 20, 2023
@pboling pboling changed the title Use with rubocop_gradual? Use with rubocop-gradual? Sep 20, 2023
@pboling
Copy link
Author

pboling commented Sep 20, 2023

Thanks for the explanation! If I ever have spare cycles, I may look into it ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants