Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/currency sign after #1982

Merged
merged 14 commits into from
Nov 11, 2018

Conversation

CodeSkills
Copy link
Collaborator

Related issues

None

Short description and why it's useful

Enable to change the position of currency sign to be prepended or appended depending on currencySignBehind i18n config value. (Default false)

Screenshots of visual changes before/after (if there are any)

screenshot 2018-11-10 at 15 07 09

Screenshot of passed e2e tests (if you are using our standard setup as a backend)

Visual & functional test

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the naming

config/default.json Show resolved Hide resolved
@CodeSkills
Copy link
Collaborator Author

@pkarw Changed the option to ENUM and added info to Docs.

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks! Please just solve the conflicts and we’re good to go :)

@CodeSkills
Copy link
Collaborator Author

Should be solved now.

@pkarw pkarw merged commit b705f52 into vuestorefront:develop Nov 11, 2018
@pkarw
Copy link
Collaborator

pkarw commented Nov 11, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants