Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1248 Adds Sklearn Pipeline tests to ModelVisualizers - CPE, ClsRpt, ConfustionMatrix, PRC, ROCAUC,DroppingCurve #1249

Merged
merged 14 commits into from
May 28, 2022

Conversation

lwgray
Copy link
Contributor

@lwgray lwgray commented May 15, 2022

Adding test for utilization of Sklearn pipelines within these ModelVisualizers

  • - ClassPredictionError
  • - ClassificationReport
  • - ConfusionMatrix
  • - PrecisionRecallCurve
  • - ROCAUC
  • - DroppingCurve

CHECKLIST

  • Is the commit message formatted correctly?
  • Have you noted the new functionality/bugfix in the release notes of the next release?
  • Included a sample plot to visually illustrate your changes?
  • Do all of your functions and methods have docstrings?
  • Have you added/updated unit tests where appropriate?
  • Have you updated the baseline images if necessary?
  • Have you run the unit tests using pytest?
  • Is your code style correct (are you using PEP8, pyflakes)?
  • Have you documented your new feature/functionality in the docs?
  • Have you built the docs using make html?

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #1249 (a0bcb55) into develop (ad0d133) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1249      +/-   ##
===========================================
+ Coverage    90.58%   90.61%   +0.03%     
===========================================
  Files           92       92              
  Lines         5213     5213              
===========================================
+ Hits          4722     4724       +2     
+ Misses         491      489       -2     
Impacted Files Coverage Δ
yellowbrick/classifier/rocauc.py 96.94% <0.00%> (+0.76%) ⬆️
yellowbrick/classifier/confusion_matrix.py 93.68% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0d133...a0bcb55. Read the comment docs.

@lwgray lwgray changed the title Add Sklearn Pipeline test to ModelVisualizers Fixes #1248 Adds Sklearn Pipeline tests to ModelVisualizers May 15, 2022
@bbengfort
Copy link
Member

@lwgray thank you for taking on this work!

@lwgray lwgray requested a review from bbengfort May 28, 2022 16:35
@lwgray lwgray changed the title Fixes #1248 Adds Sklearn Pipeline tests to ModelVisualizers Fixes #1248 Adds Sklearn Pipeline tests to ModelVisualizers - CPE, ClsRpt, ConfustionMatrix, PRC, ROCAUC,DroppingCurve May 28, 2022
Copy link
Member

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for doing all the hard work adding these tests for pipelines! I'm really glad to see that the new sklearn Pipeline supports visualizers; that's going to make things a lot easier! I also think that the 4 tests you're adding a perfect, testing visualizers in a pipeline and testing visualizers with pipelined models; excellent coverage!

For this test I:

  • spot checked old vs new baseline images for obvious big changes
  • spot checked new baseline images to make sure they had data
  • spot checked the right model was used in the tests.

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants