-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1248 Adds Sklearn Pipeline tests to ModelVisualizers - CPE, ClsRpt, ConfustionMatrix, PRC, ROCAUC,DroppingCurve #1249
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1249 +/- ##
===========================================
+ Coverage 90.58% 90.61% +0.03%
===========================================
Files 92 92
Lines 5213 5213
===========================================
+ Hits 4722 4724 +2
+ Misses 491 489 -2
Continue to review full report at Codecov.
|
… multiple values for argument 'classes'
@lwgray thank you for taking on this work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for doing all the hard work adding these tests for pipelines! I'm really glad to see that the new sklearn Pipeline supports visualizers; that's going to make things a lot easier! I also think that the 4 tests you're adding a perfect, testing visualizers in a pipeline and testing visualizers with pipelined models; excellent coverage!
For this test I:
- spot checked old vs new baseline images for obvious big changes
- spot checked new baseline images to make sure they had data
- spot checked the right model was used in the tests.
Nice one!
Adding test for utilization of Sklearn pipelines within these ModelVisualizers
CHECKLIST
pytest
?make html
?