Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair hotfix on v1.0 merge to master #725

Closed
bbengfort opened this issue Feb 6, 2019 · 1 comment
Closed

Repair hotfix on v1.0 merge to master #725

bbengfort opened this issue Feb 6, 2019 · 1 comment
Labels
priority: high should be done before next release type: technical debt work to optimize or generalize code
Milestone
v1.0

Comments

@bbengfort
Copy link
Member

bbengfort commented Feb 6, 2019 •
edited
Loading

When we released hotfix v0.9.1 we created some potential conflicts in master when merging the v1.0 release that will need to be repaired. Namely:

  1. The requirements files must match the develop version
  2. The xfails in several tests must be removed

The details of these changes can be found in #724 and 3f20db

Also, while here - please also review the classifiers in setup.py -- particularly the language classifiers and remove any reference to Python 2 (including and especially the python_requires)
@bbengfort bbengfort added the type: technical debt work to optimize or generalize code label Feb 6, 2019
@bbengfort bbengfort added this to the v1.0 milestone Feb 6, 2019
@rebeccabilbro rebeccabilbro added the priority: high should be done before next release label Feb 6, 2019
@bbengfort
Copy link
Member Author

Fixed in #957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high should be done before next release type: technical debt work to optimize or generalize code
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@bbengfort @rebeccabilbro