Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint or validate HTML fixtures in CI #421

Open
Weibye opened this issue Apr 10, 2023 · 0 comments
Open

Lint or validate HTML fixtures in CI #421

Weibye opened this issue Apr 10, 2023 · 0 comments
Labels
build system Make continuous integration do the tedious things enhancement New feature or request good first issue Good for newcomers

Comments

@Weibye
Copy link
Collaborator

Weibye commented Apr 10, 2023

What problem does this solve or what need does it fill?

Our test fixtures are humanly typed HTML.

  • There has been some cases of typos in the html which produces invalid tests. Update wrong css in test #352
  • There was also a case of a missing semicolon somewhere, but I can't seem to find the PR or commit.

What solution would you like?

  • Some form of lint or validation in CI to ensure that the HTML is correct and without obvious flaws. This would help verify that our test results are correct and can be trusted (more).

What alternative(s) have you considered?

Do nothing, it's not a large cause of issues at the moment.

@Weibye Weibye added enhancement New feature or request build system Make continuous integration do the tedious things labels Apr 10, 2023
@nicoburns nicoburns added the good first issue Good for newcomers label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Make continuous integration do the tedious things enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants