Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min_max computation when resolving flexible lengths to follow the spec #122

Closed
TimJentzsch opened this issue Jun 9, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@TimJentzsch
Copy link
Collaborator

What problem does this solve or what need does it fill?

The min_max computation when resolving flexible lengths seems to not follow the spec:
https://github.com/DioxusLabs/sprawl/blob/11701ee97d68b22a231cac081aab4308af136706/src/flexbox.rs#L669-L675

What solution would you like?

The computation should follow the spec. Otherwise, the computation should probably be refactored.

What alternative(s) have you considered?

If it works, we could keep it as-is. Probably a bad idea though.

Additional context

Originally discussed in #39.

@TimJentzsch TimJentzsch added the bug Something isn't working label Jun 9, 2022
@Weibye
Copy link
Collaborator

Weibye commented Jun 11, 2022

If it works, we could keep it as-is. Probably a bad idea though.

I agree that this should be fixed. Keeping these 'ghosts' in the code makes it harder to maintain and understand where things go wrong

@alice-i-cecile alice-i-cecile added the good first issue Good for newcomers label Jun 12, 2022
@nicoburns nicoburns mentioned this issue Jul 22, 2022
87 tasks
@nicoburns nicoburns removed the good first issue Good for newcomers label Dec 30, 2022
@nicoburns
Copy link
Collaborator

I believe this one was also fixed as part of #291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants