Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprawl::remove should return an Option<Id> #102

Closed
alice-i-cecile opened this issue Jun 8, 2022 · 1 comment · Fixed by #106
Closed

Sprawl::remove should return an Option<Id> #102

alice-i-cecile opened this issue Jun 8, 2022 · 1 comment · Fixed by #106
Assignees
@sixfold-origami
Labels
breaking-change A change that breaks our public interface code quality Make the code cleaner or prettier. good first issue Good for newcomers

Comments

@alice-i-cecile
Copy link
Collaborator

This allows users to know if the operation succeeded, and if it did, which node ID was invalidated.
@alice-i-cecile alice-i-cecile added good first issue Good for newcomers code quality Make the code cleaner or prettier. breaking-change A change that breaks our public interface labels Jun 8, 2022
@sixfold-origami
Copy link
Collaborator

I can handle this one.

@sixfold-origami sixfold-origami mentioned this issue Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sixfold-origami sixfold-origami

Labels
breaking-change A change that breaks our public interface code quality Make the code cleaner or prettier. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return a Result from Taffy::remove sixfold-origami/sprawl
2 participants
@alice-i-cecile @sixfold-origami