Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to specify own LoginBaseUrl #13

Open
Kittiman opened this issue Aug 21, 2020 · 2 comments
Open

Add possibility to specify own LoginBaseUrl #13

Kittiman opened this issue Aug 21, 2020 · 2 comments

Comments

@Kittiman
Copy link

There is a problem to use this module against a on-prem apiee installation. I suggest to add an option to specify customSSOUrl.
Meaning add this to the loginBaseUrl.js file.

module.exports = function getLoginBaseUrl(options) {
if (options.ssoZone) {
return 'https://' + options.ssoZone + '.login.apigee.com';
}
if (options.ssoUrl) {
return options.ssoUrl;
}
if (options.keyfile) {
return 'https://oauth2.googleapis.com/token';
}
if (options.customSSOUrl) {
return options.customSSOUrl;
}

return 'https://login.apigee.com';
};

@Kittiman
Copy link
Author

I suggest to add the ssoUrl as an option to the utility.js file rather then my first suggestion.

@DinoChiesa
Copy link
Owner

hi,
I pushed a change to main branch with this change. I have not yet released an updated version with this change to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants