Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments Section [discussion] #131

Closed
Rushi98 opened this issue Jul 15, 2017 · 4 comments
Closed

Comments Section [discussion] #131

Rushi98 opened this issue Jul 15, 2017 · 4 comments

Comments

@Rushi98
Copy link
Member

Rushi98 commented Jul 15, 2017

We require comments at many places. One example is #80 . There would be other places such as discussion on announcements, uploads and posts or even standalone topics which contain only discussion. Instead of developing comment sections individually for each of these, we should develop a single module (in form of a fragment, maybe?) and reuse it.

@kukreja-vikramaditya
Copy link
Contributor

Yes I agree. Using fragment will also be a good idea.
I can think of 2 cases here, maybe we can divide them and approach the issues .

  1. Quick comment section in the HomeFragment list
  2. Detailed comment section in a "Detailed Activity"

However this requires authentication and is blocked until #125 is merged

@Rushi98
Copy link
Member Author

Rushi98 commented Aug 18, 2017

Now that #43 is complete, should we complete this. Also, this will be a part of #143 .

@kukreja-vikramaditya
Copy link
Contributor

I am currently creating the backbone in #143.
Once that is completed this can be resolved

@Rushi98
Copy link
Member Author

Rushi98 commented Apr 16, 2020

closing as stale

@Rushi98 Rushi98 closed this as completed Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants