Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 버그 fix & 음원 추가 #146

Merged
merged 4 commits into from
Dec 1, 2023
Merged

[FEAT] 버그 fix & 음원 추가 #146

merged 4 commits into from
Dec 1, 2023

Conversation

JYPjoy
Copy link
Member

@JYPjoy JYPjoy commented Dec 1, 2023

🛠️ 작업 내용


👀 소개

  • 떡꼬치 버그 해결
  • 창문에 호랑이 울음소리 추가

✋ 잠깐만! 자가 체크

  • 나는 올바른 브랜치에서 작업했나요?
  • 머지하려는 브랜치의 방향이 정확한가요? 혹쉬 지금 main으로 머지하려던 건 아니겠죠?
  • PR에 내가 작업한 내용을 모두 기재했나요? 설마 귀찮다고 그냥 넘어가려던 건 아니겠죠?
  • 스스로 self-review는 했나요?
  • 내 코드에 대한 책임은 나에게 있다! PR 보냈다고 끝이 아니란 사실, 이미 잘 알고 있죠?

@JYPjoy JYPjoy requested review from nss321 and dtd1232 December 1, 2023 04:32
@JYPjoy JYPjoy self-assigned this Dec 1, 2023
@JYPjoy JYPjoy merged commit 3d85b21 into DeveloperAcademy-POSTECH:develop Dec 1, 2023
nss321
nss321 reviewed Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@nss321 nss321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nss321 nss321 nss321 left review comments

@dtd1232 dtd1232 Awaiting requested review from dtd1232

Assignees

@JYPjoy JYPjoy

Labels
♻️ Refactor 🍭 조이
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JYPjoy @nss321