Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[algoliasearch] add method addAlgoliaAgent #37105

Merged
merged 1 commit into from
Jul 24, 2019
Merged

[algoliasearch] add method addAlgoliaAgent #37105

merged 1 commit into from
Jul 24, 2019

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jul 24, 2019 •
edited
Loading

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #37105 diff
Batch compilation
Memory usage (MiB) 35.0 36.5 +4.3%
Type count 2711 2667 -1.6%
Assignability cache size 196 190 -3.1%
Subtype cache size 54 56 +3.7%
Identity cache size 0 0
Language service
Samples taken 254 256 +0.8%
Identifiers in tests 254 256 +0.8%
getCompletionsAtPosition
    Mean duration (ms) 111.0 103.6 -6.6%
    Median duration (ms) 116.5 124.3 +6.7%
    Mean CV 25.5% 24.1% -5.7%
    Worst duration (ms) 146.2 143.7 -1.7%
    Worst identifier sortFacetValuesBy QueryParameters
getQuickInfoAtPosition
    Mean duration (ms) 98.8 100.4 +1.6%
    Median duration (ms) 85.8 84.9 -1.0%
    Mean CV 25.4% 18.9% -25.5%
    Worst duration (ms) 155.2 148.4 -4.4%
    Worst identifier maxValuesPerFacet then

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

Haroenv added a commit to algolia/instantsearch that referenced this pull request Jul 24, 2019
@Haroenv
chore(core): migrate core file to TS
dc3ae36 
this depends on:

- DefinitelyTyped/DefinitelyTyped#37105
- algolia/algoliasearch-helper-js#739
@Haroenv Haroenv mentioned this pull request Jul 24, 2019
Merged
2 tasks
@typescript-bot typescript-bot added Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Jul 24, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 24, 2019 •
edited
Loading

@Haroenv Thank you for submitting this PR!

🔔 @CBaptiste @samouss @keichinger @neryortez @antoinerousseau @lucapasquale @aDEVE @dan-grayson - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@weswigham weswigham merged commit 70ba0dd into DefinitelyTyped:master Jul 24, 2019
@typescript-bot
Copy link
Contributor

I just published @types/algoliasearch@3.30.16 to npm.

@Haroenv Haroenv deleted the algolia-agent branch July 25, 2019 07:39
Haroenv added a commit to algolia/instantsearch that referenced this pull request Jul 25, 2019
@Haroenv
chore(core): migrate core file to TS
c259e21 
this depends on:

- DefinitelyTyped/DefinitelyTyped#37105
- algolia/algoliasearch-helper-js#739
Haroenv added a commit to algolia/instantsearch that referenced this pull request Jul 31, 2019
@Haroenv
chore(core): migrate core file to TS (#3984)
042733d 
* chore(core): migrate core file to TS

this depends on:

- DefinitelyTyped/DefinitelyTyped#37105
- algolia/algoliasearch-helper-js#739

* chore: undo needless change

* chore: add type info

* chore(enhanceConfiguration): prevent helper to be superfluously created (#3959)

* fix(enhanceConfiguration): create SearchParameters once less

* test: add test for hierarchicalFacets

this test failed with the old mergeDeep-based enhanceConfiguration

* create helpers outside of enhanceConfiguration

* chore: more consistent type

* getConfiguration now gets called with SearchParameters only

* update existing TS widgets to make tsc pass

* chore: change conditional style to be more readable

* chore: clarify TODO

* avoid extra constructor call

* chore: go back to old behaviour, test later

* chore: remove import

* chore: reuse parameters instance

* chore: update @types/algoliasearch

* chore: move files around

* move more (also routing now)

* chore: make index' options a subset

* chore: undo readability change

* chore: remove unusted

* chore(configure): make TS pass

* Update src/types/widget.ts
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
@Haroenv
[algoliasearch] add method addAlgoliaAgent (DefinitelyTyped#37105)
34eb4b8 
source: https://github.com/algolia/algoliasearch-client-javascript/blob/5c1ce1308749aa0807940456393aa23ae46fb9eb/src/AlgoliaSearchCore.js#L173
samouss pushed a commit to algolia/instantsearch that referenced this pull request Sep 17, 2019
@Haroenv @samouss
chore(core): migrate core file to TS (#3984)
ada1766 
* chore(core): migrate core file to TS

this depends on:

- DefinitelyTyped/DefinitelyTyped#37105
- algolia/algoliasearch-helper-js#739

* chore: undo needless change

* chore: add type info

* chore(enhanceConfiguration): prevent helper to be superfluously created (#3959)

* fix(enhanceConfiguration): create SearchParameters once less

* test: add test for hierarchicalFacets

this test failed with the old mergeDeep-based enhanceConfiguration

* create helpers outside of enhanceConfiguration

* chore: more consistent type

* getConfiguration now gets called with SearchParameters only

* update existing TS widgets to make tsc pass

* chore: change conditional style to be more readable

* chore: clarify TODO

* avoid extra constructor call

* chore: go back to old behaviour, test later

* chore: remove import

* chore: reuse parameters instance

* chore: update @types/algoliasearch

* chore: move files around

* move more (also routing now)

* chore: make index' options a subset

* chore: undo readability change

* chore: remove unusted

* chore(configure): make TS pass

* Update src/types/widget.ts
samouss pushed a commit to algolia/instantsearch that referenced this pull request Sep 17, 2019
@Haroenv @samouss
chore(core): migrate core file to TS (#3984)
1addb3b 
* chore(core): migrate core file to TS

this depends on:

- DefinitelyTyped/DefinitelyTyped#37105
- algolia/algoliasearch-helper-js#739

* chore: undo needless change

* chore: add type info

* chore(enhanceConfiguration): prevent helper to be superfluously created (#3959)

* fix(enhanceConfiguration): create SearchParameters once less

* test: add test for hierarchicalFacets

this test failed with the old mergeDeep-based enhanceConfiguration

* create helpers outside of enhanceConfiguration

* chore: more consistent type

* getConfiguration now gets called with SearchParameters only

* update existing TS widgets to make tsc pass

* chore: change conditional style to be more readable

* chore: clarify TODO

* avoid extra constructor call

* chore: go back to old behaviour, test later

* chore: remove import

* chore: reuse parameters instance

* chore: update @types/algoliasearch

* chore: move files around

* move more (also routing now)

* chore: make index' options a subset

* chore: undo readability change

* chore: remove unusted

* chore(configure): make TS pass

* Update src/types/widget.ts
samouss pushed a commit to algolia/instantsearch that referenced this pull request Sep 17, 2019
@Haroenv @samouss
chore(core): migrate core file to TS (#3984)
04ea5bf 
* chore(core): migrate core file to TS

this depends on:

- DefinitelyTyped/DefinitelyTyped#37105
- algolia/algoliasearch-helper-js#739

* chore: undo needless change

* chore: add type info

* chore(enhanceConfiguration): prevent helper to be superfluously created (#3959)

* fix(enhanceConfiguration): create SearchParameters once less

* test: add test for hierarchicalFacets

this test failed with the old mergeDeep-based enhanceConfiguration

* create helpers outside of enhanceConfiguration

* chore: more consistent type

* getConfiguration now gets called with SearchParameters only

* update existing TS widgets to make tsc pass

* chore: change conditional style to be more readable

* chore: clarify TODO

* avoid extra constructor call

* chore: go back to old behaviour, test later

* chore: remove import

* chore: reuse parameters instance

* chore: update @types/algoliasearch

* chore: move files around

* move more (also routing now)

* chore: make index' options a subset

* chore: undo readability change

* chore: remove unusted

* chore(configure): make TS pass

* Update src/types/widget.ts
Haroenv added a commit to algolia/instantsearch that referenced this pull request Oct 23, 2019
@Haroenv
chore(core): migrate core file to TS (#3984)
9b81eae 
* chore(core): migrate core file to TS

this depends on:

- DefinitelyTyped/DefinitelyTyped#37105
- algolia/algoliasearch-helper-js#739

* chore: undo needless change

* chore: add type info

* chore(enhanceConfiguration): prevent helper to be superfluously created (#3959)

* fix(enhanceConfiguration): create SearchParameters once less

* test: add test for hierarchicalFacets

this test failed with the old mergeDeep-based enhanceConfiguration

* create helpers outside of enhanceConfiguration

* chore: more consistent type

* getConfiguration now gets called with SearchParameters only

* update existing TS widgets to make tsc pass

* chore: change conditional style to be more readable

* chore: clarify TODO

* avoid extra constructor call

* chore: go back to old behaviour, test later

* chore: remove import

* chore: reuse parameters instance

* chore: update @types/algoliasearch

* chore: move files around

* move more (also routing now)

* chore: make index' options a subset

* chore: undo readability change

* chore: remove unusted

* chore(configure): make TS pass

* Update src/types/widget.ts
breeze9527 pushed a commit to breeze9527/DefinitelyTyped that referenced this pull request Jan 27, 2020
@Haroenv @breeze9527
[algoliasearch] add method addAlgoliaAgent (DefinitelyTyped#37105)
d45c706 
source: https://github.com/algolia/algoliasearch-client-javascript/blob/5c1ce1308749aa0807940456393aa23ae46fb9eb/src/AlgoliaSearchCore.js#L173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Author is Owner The author of this PR is a listed owner of the package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Haroenv @typescript-bot @weswigham