Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

Split concept of ratio and tonal #183

Open
2 tasks
IanMayo opened this issue Apr 16, 2023 · 1 comment
Open
2 tasks

Split concept of ratio and tonal #183

IanMayo opened this issue Apr 16, 2023 · 1 comment
Assignees

Comments

@IanMayo
Copy link
Contributor

IanMayo commented Apr 16, 2023

I have meet with SME to get language correct, but I want us to separate out the separate types of measurement that appear in the ratio/freq column.

Some (most) are absolute frequencies, but others are multiples of the shaft rate or other machinery related sources.

Then we can be clear in what is being displayed, and offer type-specific search input controls.

Todo

  • Check patterns for how we recognise ratio data (ratio will begin with a S character or contain x string)
  • Ensure mock data matches these patterns

We have these two concepts:

Freq

  • Source (value from standard list, or maybe unknown)
  • Freq (One or more of: number, bracketed range, labelled value. 2, 2-5, 6 (Max))
  • Harmonics (H then one or more of: number, bracketed range)
  • Remarks (text, optionally multi-para)

Ratio

  • Source (value from standard list, or maybe unknown)
  • RatioType (one of SR, BR, CSR, CFR). Note I have now learned that there can be multiple CFRs. So multiple diesel engines on the platform, with separate typical frequencies for each.
  • Ratio (multiplier. Currently like 12 x CSR, but in future will just be 12)
  • Harmonics (H then one or more of: number, bracketed range)
  • Remarks (text, optionally multi-para)
@IanMayo IanMayo self-assigned this Apr 17, 2023
@IanMayo IanMayo added the onsite requires onsite access label Apr 17, 2023
@IanMayo
Copy link
Contributor Author

IanMayo commented May 11, 2023

Ok @rnllv . This is a real can of worms. I'm excited about doing it, but for Phase-1 we have to concentrate on an editable DITA document. So, we (reluctantly) have to defer this intelligent data exploitation for Phase-2.

I suggest that we treat this data as pure text for now. For Phase-2 we will parse DITA, and transition from a free text field to something more structured.

@IanMayo IanMayo removed the onsite requires onsite access label Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant