Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize naming in loaders #1425

Closed
12 tasks
23pointsNorth opened this issue Aug 28, 2023 · 1 comment
Closed
12 tasks

Standardize naming in loaders #1425

23pointsNorth opened this issue Aug 28, 2023 · 1 comment

Comments

@23pointsNorth
Copy link

23pointsNorth commented Aug 28, 2023

🚀 Feature Request

There has been a few mismatches between the naming conventions and input params. It would be great to standardize those, as to make code re-use much easier. To name a few:

  • In COCO segmentation/deteciton there is a difference between the loader expecting data_dir and root_dir.
  • The classes capitalization is following different standards as well COCODetectionDataset vs CoCoSegmentationDataSet.
  • There is coco_segmentation_dataset_params, but no coco_detection_dataset_params, but coco_detection_{network structure}_dataset_params. Change the segmentation to follow the same standard?
  • Similarly dataloaders.coco_segmentation_train vs dataloaders.coco2017_train_yolo_nas.
  • define a __str__ representation for the loaders, to avoid <torch.utils.data.dataloader.DataLoader object at 0x7fadc1d16620>
  • segmentation has train_loader.dataset.dataset_classes_inclusion_tuples_list, but detection doesn't. A common set of params?

edit: (a few more)

  • DetectionMetrics, PoseEstimationMetrics, and PreprocessSegmentationMetricsArgs
  • In tutorials/colabs - train_loader, train_dataloader, train_data, val_loader, valid_loader.
  • coco2017_rescoring_train is actually using coco2017_pose_rescoring_*
  • Fix Fixme in documentation
  • In link above PoseEstimationMetrics comment/code section error.
  • the metrics_to_watch is "target_IoU" for *_metrics_list that includes BinaryIoU(), but the metric is just "IoU" if it's a multiclass case with the metrics list including IoU().

Proposed Solution (Optional)

No response

@BloodAxe
Copy link
Collaborator

Hey. Thanks for the report. Indeed, the naming scheme is not consistent across the config files & models.
And in fact we already started looking into standardizing it. At this point it is hard to give an accurate estimate when exactly this will be introduced.

But you may keep an eye on #1421 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants