Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse user replays to report scores, validate decks and submit to TOs #20

Open
AlphaKretin opened this issue Jun 23, 2020 · 4 comments
Open
Labels
future Currently out-of-scope feature to be added in the long term

Comments

@AlphaKretin
Copy link
Contributor

Currently reporting scores is restricted to the tournament organisers, but given they have the ability to override a falsified score it could potentially be safe enough to let users report scores for their own games. Maybe this could be an option toggled per-tournament, so that it could be enabled for only more casual games? This would require making tournament creation more unwieldly though.

@AlphaKretin AlphaKretin added enhancement New feature or request question Further information is requested labels Jun 23, 2020
@kevinlul
Copy link
Contributor

What if both involved must confirm the score, just like match slips? I know that yrpX replay uploading isn't part of the initial user story.

@AlphaKretin
Copy link
Contributor Author

I've definitely considered replay uploading as something that would be nice to support - it would also enable fun future features like analytics. The issue is that one match is 2-3 replays, and uploading multiple files is multiple messages, at least through the Discord user client.

Could have it so that a user uploading a new replay (compare saved md5 hashes or something) adds one score to the match they're in (there'd still be a level of honour system here as we can't expect EDOPro usernames to match up with player names), and when one player in that match has 2 points it declares the winner (but could still support a third replay being added in case things were out of order).

@kevinlul
Copy link
Contributor

We don't have to use the honour system because we can match the player decks that we already have to the players in the replay, or reject the replay. Still, replay parsing in TypeScript is definitely way beyond the scope of the first iterations, so I was actually only thinking of sending replays to help the TO, but that's still some ways away since we have no object storage capabilities outside of Discord.

@AlphaKretin
Copy link
Contributor Author

Oh, of course, deck validation! Yeah, this is OOS for right now but definitely something I want to investigate in the future.

@AlphaKretin AlphaKretin changed the title Consider allowing participants to self-report scores Parse user replays to report scores, validate decks and submit to TOs Jun 24, 2020
@AlphaKretin AlphaKretin added future Currently out-of-scope feature to be added in the long term and removed question Further information is requested labels Jun 24, 2020
@kevinlul kevinlul removed the enhancement New feature or request label Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future Currently out-of-scope feature to be added in the long term
Projects
None yet
Development

No branches or pull requests

2 participants