Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq middleware throws an error if no options are passed. #91

Closed
tpendragon opened this issue Mar 14, 2017 · 4 comments
Closed

Sidekiq middleware throws an error if no options are passed. #91

tpendragon opened this issue Mar 14, 2017 · 4 comments
Assignees
Milestone

Comments

@tpendragon
Copy link

If I do as the docs suggest and do this:

Sidekiq.configure_server do |config|
  config.server_middleware do |chain|
    chain.add(Datadog::Contrib::Sidekiq::Tracer)
  end
end

it tells me that it expected 1 argument for Tracer and got 0. If I pass some argument to Tracer as in the next part of the docs, it works. I think Tracer just needs adjusted so it looks like so:

      class Tracer
        def initialize(options = {})
@ufoot ufoot added this to the 0.6.0 milestone Mar 21, 2017
@ufoot
Copy link
Member

ufoot commented Mar 21, 2017

Thanks for the report!

@ufoot
Copy link
Member

ufoot commented Mar 22, 2017

I think #93 should fix this.

@ufoot ufoot self-assigned this Mar 28, 2017
@gingerlime
Copy link
Contributor

When is 0.6.0 due out? I was told Monday by your support... looking forward to getting this fix out officially.

@ufoot
Copy link
Member

ufoot commented Mar 28, 2017

It should be building right now, release in process.

@ufoot ufoot closed this as completed Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants