DCJ-34: Configure vite for optimized dependencies #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passing run #3470 ↗︎
Details:
Review all test suite changes for PR #1649 ↗︎ |
|||||||||||||||
rushtong
requested review from
aarohinadkarni and
okotsopoulos
and removed request for
a team
okotsopoulos
approved these changes
May 6, 2024
There was a problem hiding this comment.
Thanks for taking this one -- given the 10 successful runs I hope that means we're in the clear!
RE: e2e flakiness, that looks like a different root cause and is not yet ticketed. Relevant Slack discussion: https://broadinstitute.slack.com/archives/C06SG4VM746/p1714969377055109
aarohinadkarni
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-34
Summary
Add a config to address the issue described here as seen in our automated unit test failures
List of GHA reruns here: https://github.com/DataBiosphere/jade-data-repo-ui/actions/runs/8958104129?pr=1649
Note: There also seems to be a flaky e2e test that is not addressed by this PR.