Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the warning in console #529

Merged
merged 2 commits into from
Dec 2, 2021
Merged

fix: remove the warning in console #529

merged 2 commits into from
Dec 2, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复控制台的警告

主要变更

  • 移除如下警告:
    - Warning: Failed prop type: Invalid prop `className` of type `boolean` supplied to `Pane`, expected `string`.
    - Warning: React does not recognize the `sortIndex` prop on a DOM element.
    - Warning: React does not recognize the `actionBar` prop on a DOM element. 
  • 未移除警告如下:
  • Warning: Render methods should be a pure function of props and state.(需要对 useContextMenu 进行重构)

@mortalYoung mortalYoung added the bug Something isn't working label Dec 1, 2021
@mortalYoung mortalYoung self-assigned this Dec 1, 2021
@wewoor
Copy link
Collaborator

wewoor commented Dec 1, 2021

@mortalYoung 处理下单测

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshots 应该需要更新

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #529 (69519dd) into main (8802b1f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage   86.55%   86.56%           
=======================================
  Files         188      188           
  Lines        5498     5499    +1     
  Branches     1226     1226           
=======================================
+ Hits         4759     4760    +1     
  Misses        729      729           
  Partials       10       10           
Impacted Files Coverage Δ
src/workbench/statusBar/item.tsx 100.00% <100.00%> (ø)
src/workbench/workbench.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8802b1f...69519dd. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 059016c into main Dec 2, 2021
@wewoor wewoor deleted the fix/warning branch December 2, 2021 05:52
wewoor pushed a commit that referenced this pull request Dec 2, 2021
* fix: remove the warning in console

* test: update snapshots
wewoor added a commit that referenced this pull request Dec 6, 2021
* docs: update the introduction

* docs: update the Introduction of zhCN version

* docs: tutorials for keybinding, quickAccess and Icon

* feat: improve homepage (#527)

* build: update the limitation of node version (#515)

* fix: fix can't clear the notifications (#518)

* fix: fix can't clear the notifications

* test: update tests

* test: ignore render tests

* fix: fix create file node incorrect on contextMenu (#522)

* refactor:  optimize the MoleculeProvider (#517)

* refactor: update the MoleculeProvider

* fix(molecule provider): init workbench ui after init locales

* test: unit test for splitLanguagesExts

* docs: comments for MoleculeProvider

* test: unit test for MoleculeProvider

* refactor(i18n): update the apis of locales

* fix: correct the reset to rest

* chore: ignore website prettier

* style: prettify code

* test: update the snapshot case

* test: remove the snapshot

* test: update snapshot

* ci:  yarn test -u

* ci: remove the -u argument of yarn test

* test: update the MoleculeProvider snap

* fix: show the SubMenu in right place when the Menu is horizontal mode (#526)

* fix: show the submenu in right place when horizontal mode

* test: update the snap of Menu

* feat: support sort in folderTree (#524)

* feat: support sort in folderTree

* feat: improve check hidden files

* docs: update Guides

* docs: unify the files name

* docs: update Guides, Overview

* docs: update the QuickStart

* docs: update the first extension

* docs: update the extension guides

* docs: update Workbench UI

* fix: improve the circular dep error when execute yarn link (#528)

* fix: remove the warning in console (#529)

* fix: remove the warning in console

* test: update snapshots

* docs: update ColorTheme, readme, keybinding, i18n

* docs: update Keybinding

* docs: update quickAccess, add demo tips

* docs: update i18n

* docs: update Settings guide

* docs: update Icon guide

* docs: update customize the Workbench guide

* docs: update images

* docs: update Contributing

* docs: update English version

* fix: remove the 140 width limit for buttons

* docs: default locale is zh-CN

* docs: improve the links (#533)

Co-authored-by: 野迂迂 <yangwei1@outlook.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants