Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize the Color Theme #395

Merged
merged 8 commits into from
Sep 7, 2021
Merged

fix: optimize the Color Theme #395

merged 8 commits into from
Sep 7, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Sep 3, 2021

Overview

优化 Color theme

Changes

  • 优化 miniMap 根据Theme切换后的背景颜色
  • 优化 scrollbar 的Theme
  • 优化 ActivityBar
  • 优化 MenuBar 颜色,大小
  • 优化 Panel Title active 的状态色

@wewoor wewoor self-assigned this Sep 3, 2021
@wewoor wewoor added the bug Something isn't working label Sep 3, 2021
@wewoor wewoor added this to the 0.9.0-alpha.5 milestone Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #395 (3073380) into main (73cca0d) will increase coverage by 2.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   76.84%   79.26%   +2.41%     
==========================================
  Files         176      176              
  Lines        4837     4851      +14     
  Branches     1041     1045       +4     
==========================================
+ Hits         3717     3845     +128     
+ Misses       1112      999     -113     
+ Partials        8        7       -1     
Impacted Files Coverage Δ
src/services/theme/colorRegistry.ts 100.00% <ø> (ø)
src/model/workbench/layout.ts 100.00% <100.00%> (ø)
src/services/theme/helper.ts 100.00% <100.00%> (ø)
src/components/tabs/tab.tsx 100.00% <0.00%> (ø)
src/workbench/editor/action.tsx 2.63% <0.00%> (ø)
src/workbench/sidebar/explore/explore.tsx 80.00% <0.00%> (ø)
src/model/workbench/explorer/editorTree.ts 80.00% <0.00%> (ø)
...c/services/workbench/explorer/editorTreeService.ts 100.00% <0.00%> (ø)
src/controller/explorer/editorTree.tsx 46.34% <0.00%> (+0.18%) ⬆️
src/components/actionBar/index.tsx 97.43% <0.00%> (+2.56%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73cca0d...3073380. Read the comment docs.

src/services/theme/helper.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 9a6ed01 into main Sep 7, 2021
@wewoor wewoor deleted the fix/colorTheme branch September 7, 2021 06:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants