Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and Extract LayoutService #176

Merged
merged 14 commits into from
Jun 21, 2021
Merged

Design and Extract LayoutService #176

merged 14 commits into from
Jun 21, 2021

Conversation

mumiao
Copy link
Collaborator

@mumiao mumiao commented Jun 10, 2021

Resolved #173

export interface ILayoutService extends Component{    
    setMenuBarHidden(): void;
    setSideBarHidden(): void;
    setPanelHidden(): void; 
    setActivityBarHidden(): void; 
    setStatusBarHidden(): void;   
    setPaneSize(splitPanePos: string[]): void;  
    setHorizontalPaneSize(horizontalSplitPanePos: string[]): void; 
    togglePanelMaximized(): void;   
    isPanelMaximized(): boolean | undefined;
    getContainer(domId: string): HTMLElement 
    setSideBarPosition(position: Position): void;
    getSideBarPosition(): Position;
    conatiner: HTMLElement | null;
}

@mumiao mumiao changed the title Design and Extract LayoutService 【WIP】Design and Extract LayoutService Jun 10, 2021
@mumiao mumiao self-assigned this Jun 10, 2021
@mumiao mumiao added the feature label Jun 10, 2021
@mumiao mumiao added this to the 0.9.0-alpha.3 milestone Jun 10, 2021
src/services/workbench/layoutService.ts Outdated Show resolved Hide resolved
src/services/workbench/layoutService.ts Show resolved Hide resolved
src/services/workbench/panelService.ts Outdated Show resolved Hide resolved
src/workbench/workbench.tsx Show resolved Hide resolved
@mumiao mumiao changed the title 【WIP】Design and Extract LayoutService Design and Extract LayoutService Jun 16, 2021
@mumiao mumiao requested a review from wewoor June 16, 2021 03:56
@mumiao mumiao added enhancement New feature or request refactoring Refactor and removed feature labels Jun 16, 2021
src/services/workbench/activityBarService.ts Outdated Show resolved Hide resolved
src/services/workbench/layoutService.ts Outdated Show resolved Hide resolved
src/monaco/monacoService.ts Outdated Show resolved Hide resolved
src/services/workbench/layoutService.ts Show resolved Hide resolved
@wewoor wewoor mentioned this pull request Jun 17, 2021
constructor() {
super();
this.state = container.resolve(LayoutModel);
this._container = document.getElementById(ID_APP) || document.body;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layoutService container 的初始化,必须要再 MoleculeProvide DidMount 中去执行,ID_APP 目前是指Workbench View, 这个会存在实例化 layoutService 的时候,container 始终是 body 元素的问题

@wewoor wewoor merged commit a15245f into main Jun 21, 2021
@wewoor wewoor deleted the refactor_layout branch June 21, 2021 03:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Layoutservice
3 participants