Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaguya TC - invalid BandBin values set at ingestion #5629

Open
lwellerastro opened this issue Oct 8, 2024 · 0 comments
Open

Kaguya TC - invalid BandBin values set at ingestion #5629

lwellerastro opened this issue Oct 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@lwellerastro
Copy link
Contributor

lwellerastro commented Oct 8, 2024

ISIS version(s) affected: 8.3.0 and all prior versions supporting Kaguya TC ingestion

Description
Applications using BandBin keywords fail due to improperly set values:

 Group = BandBin
    FilterName = BroadBand
    Center     = 640nm
    Width      = 420nm
  End_Group

Kaguay TC images passed to photomet produce the following error:

  Group = Error
    Program = photomet
    Code    = 1
    Message = "Failed to convert string [640nm] to a double"
    File    = IString.cpp
    Line    = 196
  End_Group

How to reproduce
Data are available in my user work area under Isis3Tests/KaguyaTC/MiscIngestion/BandBinVal/. There are 2 Kaguya TC images (img and lbl) available for ingestion to demonstrate the problem.

kaguyatc2isis from=TC1W2B0_01_00295N398E2404.lbl to=TC1W2B0_01_00295N398E2404.cub 
kaguyatc2isis from=TC2S2B0_01_03136S506E2381.lbl to=TC2S2B0_01_03136S506E2381.cub

Spiceinit will need to be run on the images first to reproduce the photomet error.

spiceinit from=TC1W2B0_01_00295N398E2404.cub spksmithed=true
spiceinit from=TC2S2B0_01_03136S506E2381.cub spksmithed=true
photomet from=TC1W2B0_01_00295N398E2404.cub to=TC1W2B0_01_00295N398E2404.pho.cub frompvl=basicpho.pvl
photomet from=TC2S2B0_01_03136S506E2381.cub to=TC2S2B0_01_03136S506E2381.pho.cub frompvl=basicpho.pvl

Possible Solution
The BandBin group is created and populated upon ingestion and must be handled by a translation file (I don't actually see anything being set by the trn file though) or directly by the ingestion app (yeah, it's hard coded there incorrectly) because the keyword does not exist anywhere in the .lbl label file.

Photomet will run if I run editlab on existing images and set keyword=center keyvalue="640" which is what I intend on doing to all of my data to keep working, but setting keyvalue="640 " still produces errors likely because of cube byte size limitations already set by existing keyword/keyvalues (I'm guessing, but editing existing keywords can be tricky if the new values aren't the same length as what is being replaced).

Additional context

@lwellerastro lwellerastro added the bug Something isn't working label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant