Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of optimizer with older DQN models #1978

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

araffin
Copy link
Member

@araffin araffin commented Jul 24, 2024

Description

Should fixed DLR-RM/rl-baselines3-zoo#466

introduced in #1963

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@araffin araffin requested a review from qgallouedec July 24, 2024 11:27
@qgallouedec
Copy link
Collaborator

Lgtm, I haven't tried locally. I will, in the meantime, I approve.

@araffin
Copy link
Member Author

araffin commented Jul 26, 2024

I will do a alpha release on pypi too

@araffin araffin merged commit bd3c0c6 into master Jul 26, 2024
4 checks passed
@araffin araffin deleted the fix/dqn-loading branch July 26, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants