-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix check_env for Sequence observation space #1690
Conversation
Hello,
looks good but you should add a test. |
I launched the test and it was ok up until 94%. Then I had a segmentation fault (error 139) : """ I didn't see any similar case in the issues. Do you know why it could have happened ? (I already had this problem when I launched the test for another issue) |
you can safely ignore that test. |
I am kind of confused about the test you talked about . You meant adding an automatic test in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks =)
You're welcome ! Thanks for the lib (: |
Add a condition to check if observation space of an environment is Sequence in the "_check_unsupported_spaces". Add a condition to stop the "check_env" function is this type of obs space is detected (only if warn=True).
Should I solve the issue a different way ?
I had a segmentation fault error while running make pytest.
Description
closes #1683
Motivation and Context
Types of changes
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line