Fixed typo in libics that caused out-of-bounds read. Fixes #81.

DIPlib · Aug 12, 2021 · d7d7155 · d7d7155
1 parent 7db8485
commit d7d7155
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/changelogs/diplib_3.1.0.md b/changelogs/diplib_3.1.0.md
@@ -100,6 +100,8 @@ title: "Changes DIPlib 3.1.0"
 
 - `dip::MeanAbs()` and `dip::SumAbs()` could produce wrong results for complex inputs.
 
+- libics had a typo that caused out-of-bounds read (#81). 
+
 
 
 

diff --git a/dependencies/libics/libics_read.c b/dependencies/libics/libics_read.c
@@ -897,7 +897,7 @@ Ics_Error IcsReadIcs(Ics_Header *icsStruct,
             for (sj = 0, si = 0; si < parameters; si++) {
                 if (si == bits) {
                     icsStruct->imel.origin = origin[si];
-                    icsStruct->imel.scale = scale[i];
+                    icsStruct->imel.scale = scale[si];
                     strcpy(icsStruct->imel.unit, unit[si]);
                 } else {
                     icsStruct->dim[sj].size = sizes[si];