Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval-machines: remove .drv file which pulls in unneeded deps #91

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

flokli
Copy link

@flokli flokli commented Nov 20, 2019

all credit goes to @delroth - proposed in #69 (comment)

I'm running this since quite some time on my systems, and it's a huge time (and bandwidth)-saver.

@johanot
Copy link
Contributor

johanot commented Nov 21, 2019

Thanks for this!
It likely requires that we internally wrap morph with other build targets, since we actively use the drv on the target machines, but that's not your headache. :) We just need to do some testing real quick - I'll be back for a probable merge soon.

This definitely requires at least a release-note, but overall I think it's a more sensible default for morph.

@flokli
Copy link
Author

flokli commented Nov 21, 2019

Great to hear! I agree this probably should be part of the release notes. I assume release notes are only on https://github.com/DBCDK/morph/releases, are they? Couldn't find those in the repo, otherwise I would have included in this PR ;-)

morph stopped pushing .drv files to targets, only the nix paths, leading to a much smaller amount of data to be transferred.

Copy link
Contributor

@johanot johanot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Local tests are ok. We'll make sure to write something about this on the next release. Yes; release notes are currently on the Github Releases page only. We might change that at some point :-)

@johanot johanot merged commit e4f497f into DBCDK:master Nov 25, 2019
@flokli flokli deleted the remove-drv branch December 21, 2019 17:01
@flokli
Copy link
Author

flokli commented Dec 21, 2019

@johanot small nag - any plans to do the next release?

@johanot
Copy link
Contributor

johanot commented Jan 10, 2020

@flokli better late than never :) https://github.com/DBCDK/morph/releases/tag/v1.4.0

@flokli
Copy link
Author

flokli commented Jan 10, 2020

Thanks a ton! nixpkgs PR: NixOS/nixpkgs#77431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants