Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle update causes app to begin to fail #1131

Closed
lomky opened this issue Jul 11, 2017 · 4 comments · Fixed by #1123
Closed

bundle update causes app to begin to fail #1131

lomky opened this issue Jul 11, 2017 · 4 comments · Fixed by #1123
Labels

Comments

@lomky
Copy link
Member

lomky commented Jul 11, 2017

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

  • What are we trying to do?

    • Keep everything running smoothly!
  • What feature or behavior is this required for?

    • being able to safely run bundle update
  • How could we solve this issue? (Not knowing is okay!)

    • I'm very suspicious of the platform-api line in our Gemfile @colinxfleming says its a legacy gem from before Heroku gave us a cert, but somewhat hard to extract from our system.
  • Anything else?

Reproduce by checking out master, running rake test (tests should start, cancel out), run bundle update (tests will fail to run).

@lomky lomky added the bug label Jul 11, 2017
@lomky
Copy link
Member Author

lomky commented Jul 11, 2017

After I commented out platform-api, faker began throwing an error. Seems to be a problem for others as well

@lomky
Copy link
Member Author

lomky commented Jul 12, 2017

faker released an update rolling back their error.
platform-api is still causing trouble. Commenting it out of the Gemfile & running bundle update allows the server to start again, but we should probably extract the gem more carefully than that.

@colinxfleming
Copy link
Member

platform-api is being shot into space via #1137 and #958 , which I hope to have into production tomorrow. (I think Heroku has a much smoother process around this now.) tough break for faker, yikes.

There are two open 'update a bunch of dependencies' PRs ( #1122 and #1123 ), so that hopefully fixes a good part of this. @lomky what say we call this good when we get our gemnasium badge to change from update! to green?

@colinxfleming
Copy link
Member

Platform-api is gone. One down one to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants