Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds configurable hosts for hamilton ui #999

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Jun 28, 2024

Settings mini is used by default by the Hamilton UI command. This changes it to enable changing
ALLOWED_HOSTS by passing in some environment variables.

It then automatically adds a few of them, like the current IP, etc.

Changes

  • settings_mini.py

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exception -> warning I think?

Settings mini is used by default by the Hamilton UI
command. This changes it to enable changing
ALLOWED_HOSTS by passing in
some environment variables.

It then automatically adds a few of them, like
the current IP, etc.
@skrawcz
Copy link
Collaborator Author

skrawcz commented Jun 28, 2024

exception -> warning I think?

sure. I copied from yours.

@skrawcz skrawcz merged commit 8cf5af0 into main Jul 1, 2024
21 checks passed
@skrawcz skrawcz deleted the adjust_mini_settings branch July 1, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants