Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles case where input was series with time index #951

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Jun 12, 2024

So we need to fix the inputs and introspecting them. This is a quick fix to not fail when someone applies the SDK to the quick start example.

Changes

  • SDK
  • tests for SDK

How I tested this

  • locally
  • Unit tests

Notes

  • this was flagged by a user who was trying out the quick start and then plug in the SDK.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

So we need to fix the inputs and introspecting them. This is
a quick fix to not fail when someone applies the SDK to the
quick start example.
It changed behavior.
@skrawcz skrawcz merged commit b89c019 into main Jun 13, 2024
26 checks passed
@skrawcz skrawcz deleted the temp_fix_sdk_inputs branch June 13, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant