[Async]HamiltonTracker support passing in custom CA cert #1105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Hamilton UI server is fronted by an SSL using an internal CA, which isn't supported by Hamilton SDK without this PR.
The standard synchronous
HamiltonTracker
can be worked around by usingos.environ["REQUESTS_CA_BUNDLE"]
but that's not ideal. TheAsyncHamiltonTracker
has no such workaround available & we are switching to using that.Changes
Trackers take a new optional
verify
arg which mimics therequests
arg of the same name.How I tested this
Both adapters tested on our internal network
Notes
Checklist