Use envsubst to allow frontend to find backend with env vars #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This structure more naturally fits what docker expects. A docker-compose file at the root, with docker files for the respective services in those modules. I have tested this locally for the prod build and pushed things and I believe it works for the other cases too. TODO: - dockerx build instructions - automating the build & versioning of images with new releases
…e forwarding docker-compose to docker compose
This structure more naturally fits what docker expects. A docker-compose file at the root, with docker files for the respective services in those modules. I have tested this locally for the prod build and pushed things and I believe it works for the other cases too. TODO: - dockerx build instructions - automating the build & versioning of images with new releases
skrawcz
force-pushed
the
reorganize_docker
branch
from
8dd40e6
to
6f264a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker compose is a great simple orchestration system, but for production purposes we need to support others, for which the hardcoding of backend:port in the frontend nginx.conf is far from ideal...we can use modern nginx docker ability to use envsubst to achieve this instead, which allows full control via ENV vars
Changes
How I tested this
Used a custom ui-frontend which I built from this script...other dockers were identical.
Notes
Checklist