Raise error on empty arguments to group
#1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! If you rebase off of Otherwise mind writing a test? Should be as simple as adding a line here with an empty args/kwargs, probably don't have to run locally. . |
| @@ -176,6 +176,9 @@ def _validate_group_params( | |||
| f"Dependency: {dependency} is not a valid dependency type for group(), must be " | |||
| f"a LiteralDependency or UpstreamDependency." | |||
| ) | |||
| raise InvalidDecoratorException( | |||
There was a problem hiding this comment.
This will always raise, no? Will want to add return statements above or something to get it to work.
There was a problem hiding this comment.
Or an if statement for both of them
|
Looking good! Mind rebasing off of |
add test for invalid dependencies
elijahbenizzy
approved these changes
Jul 5, 2024
| @@ -176,6 +176,9 @@ def _validate_group_params( | |||
| f"Dependency: {dependency} is not a valid dependency type for group(), must be " | |||
| f"a LiteralDependency or UpstreamDependency." | |||
| ) | |||
| raise InvalidDecoratorException( | |||
There was a problem hiding this comment.
Or an if statement for both of them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1007
How I tested this
Hand testing.
Checklist