Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in JA3Digest #13

Closed
kjelle opened this issue May 16, 2019 · 2 comments
Closed

Error in JA3Digest #13

kjelle opened this issue May 16, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@kjelle
Copy link

kjelle commented May 16, 2019 •
edited
Loading

Hello.
There seem to be an error in how the JA3Digest is outputted for some PCAPs. There are two bugs:

  • The EllipticCurves part might be ending with a dash (-), probably from some GREASE filtering.
  • The EllipticCurves field is missing the GREASE filtering.

Example:

771,49195-49199-49196-49200-52393-52392-49171-49172-156-157-47-53-10,65281-0-23-35-13-5-18-16-30032-11-10-,64250-29-23-24,0

Im preparing a patch.
@kjelle kjelle mentioned this issue May 16, 2019
Closed
@gallypette gallypette added the bug Something isn't working label May 16, 2019
@gallypette
Copy link
Member

gallypette commented May 16, 2019 •
edited
Loading

Yep your are totally right - Elliptics are missing GREASE filtering.
I reckon it causes the trailing dash too.

Im preparing a patch.

I am looking forward to it !

@gallypette
Copy link
Member

This should be addressed by 01695ba
Reopen if you experience failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gallypette @kjelle