fix: provide initial value to avoid reducing empty array

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Reduce_of_empty_array_with_no_initial_value
Cryptkeeper · Jun 7, 2021 · 0f297b7 · 0f297b7
1 parent af23014
commit 0f297b7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/assets/js/scale.js b/assets/js/scale.js
@@ -39,7 +39,7 @@ export class RelativeScale {
     // https://stackoverflow.com/questions/63705432/maximum-call-stack-size-exceeded-when-using-the-dots-operator/63706516#63706516
     const max = nonNullData.reduce((a, b) => {
       return Math.max(a, b)
-    })
+    }, 0)
 
     return RelativeScale.scale(
       [0, RelativeScale.isFiniteOrZero(max)],
@@ -70,10 +70,10 @@ export class RelativeScale {
       // https://stackoverflow.com/questions/63705432/maximum-call-stack-size-exceeded-when-using-the-dots-operator/63706516#63706516
       const min = nonNullData.reduce((a, b) => {
         return Math.min(a, b)
-      })
+      }, 0)
       const max = nonNullData.reduce((a, b) => {
         return Math.max(a, b)
-      })
+      }, 0)
 
       return {
         min: RelativeScale.isFiniteOrZero(min),

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -1,3 +1,6 @@
+**5.6.0** *(June 7 2021)*
+- Fixed a regression caused by rendering error fixed in 5.5.9. See https://github.com/Cryptkeeper/Minetrack/issues/257
+
 **5.5.9** *(May 31 2021)*
 - Added configuration option to enable/disable ping failure logging.
 - Fixed a rendering error when the primary historical graph has too many data points.

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "minetrack",
-  "version": "5.5.9",
+  "version": "5.6.0",
   "description": "A Minecraft server tracker that lets you focus on the basics.",
   "dependencies": {
     "finalhandler": "^1.1.2",