Inconsistent return of contractAddress from keeper/init()?

[assafmo]

Hi guys 👋, when there are errors in keeper/init(), why is contractAddress returned here [1][2] but not here [1][2][3][4][5]?

[alpe]

Good 👁️ . In idiomatic Go all other values should be ignored when an error is returned. Therefore the contractAddress should have no effect. But we can clearly improve this by returning nil in all error cases.
Do you want to do the PR?

[assafmo]

Yeah, sure. Thanks for confirming.

[ethanfrey]

Also, in the sdk, when you return an error result, all events and data from the execution are ignored, just an error message is returned. So for the client, this is always invisible.