Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache wasmer_runtime_core::Instance instead of cosmwasm_vm::Instance #137

Closed
webmaster128 opened this issue Jan 28, 2020 · 3 comments
Closed
Milestone

Comments

@webmaster128
Copy link
Member

Caching the lower level wasmer_runtime_core::Instance would allow us to remove the public function cosmwasm_vm::Instance.set_gas and instead pass the limit at construct time (as shown in #136).

This would require the ability to preserve cosmwasm_vm::Instance.wasmer_instance when the container Instance is destructed in store_instance, just like storage.

Postponing this for now as not urgent.

@webmaster128
Copy link
Member Author

@webmaster128
Copy link
Member Author

Done in #140 on branch 0.7

@ethanfrey
Copy link
Member

We can close this as well. All this cleanup is 0.7 stuff

@webmaster128 webmaster128 added this to the 0.7.0 milestone Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants