[DP-1302] don't step on SHELL (#21)

* [DP-1302] don't step on SHELL * update CODEOWNERS
ConsultingMD · Sep 1, 2022 · 9ad1697 · 9ad1697
1 parent b855a75
commit 9ad1697
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 9 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1 +1 @@
-* @ConsultingMD/platform
+* @ConsultingMD/developer-platform
diff --git a/lib/core/shell/custom/99_bash.sh b/lib/core/shell/custom/99_bash.sh
@@ -5,7 +5,6 @@
 # module is updated
 
 # Only continue if we're on bash
-SHELL=$(ps -cp "$$" -o command="")
-if [[ ! $SHELL =~ "bash" ]]; then
+if [[ ! $(ps -cp "$$" -o command="") =~ "bash" ]]; then
   return 0
 fi
diff --git a/lib/core/shell/custom/99_zsh.sh b/lib/core/shell/custom/99_zsh.sh
@@ -6,7 +6,6 @@
 # formula is updated
 
 # Only continue if we're on zsh
-SHELL=$(ps -cp "$$" -o command="")
-if [[ ! $SHELL =~ "zsh" ]]; then
+if [[ ! $(ps -cp "$$" -o command="") =~ "zsh" ]]; then
   return 0
 fi
diff --git a/lib/core/shell/default/99_bash.sh b/lib/core/shell/default/99_bash.sh
@@ -13,8 +13,7 @@
 # Changes will be overwritten if you update the ih-core formula
 
 # Only continue if we're on bash
-SHELL=$(ps -cp "$$" -o command="")
-if [[ ! $SHELL =~ "bash" ]]; then
+if [[ ! $(ps -cp "$$" -o command="") =~ "bash" ]]; then
   return 0
 fi
 

diff --git a/lib/core/shell/default/99_zsh.sh b/lib/core/shell/default/99_zsh.sh
@@ -14,8 +14,7 @@
 # Changes to this file will be overwritten if you update the ih-core formula
 
 # Only continue if we're on zsh
-SHELL=$(ps -cp "$$" -o command="")
-if [[ ! $SHELL =~ "zsh" ]]; then
+if [[ ! $(ps -cp "$$" -o command="") =~ "zsh" ]]; then
   return 0
 fi