Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filecoin mode #1027

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Remove filecoin mode #1027

merged 4 commits into from
Oct 15, 2024

Conversation

usmansaleem
Copy link
Contributor

PR Description

Remove filecoin mode

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@usmansaleem usmansaleem added the doc-change-required Indicates an issue or PR that requires doc to be updated label Oct 15, 2024
@usmansaleem usmansaleem self-assigned this Oct 15, 2024
jframe
jframe approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem merged commit b2f1506 into Consensys:master Oct 15, 2024
6 checks passed
@usmansaleem usmansaleem deleted the remove_fc_mode branch October 15, 2024 04:01
@joaniefromtheblock joaniefromtheblock mentioned this pull request Oct 17, 2024
Closed
@joaniefromtheblock joaniefromtheblock removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees

@usmansaleem usmansaleem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usmansaleem @jframe @joaniefromtheblock