PART 2 - GET/Attestation Pool API - Retrieve attestations and metadata

[mehdi-aouadi]

PR Description

Rebased on top of #8431
Retrieve attestations and metadata for the GET attestations from aggregation pool API

Fixed Issue(s)

#8029

Documentation

• I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

• I thought about adding a changelog entry, and added one if I deemed necessary.

[greptile-apps]

PR Summary

• Added spec parameter to NodeDataProvider constructor in DataProvider.java
• Implemented getAttestationsAndMetaData tests in NodeDataProviderTest.java
• Modified getAttestations in AggregatingAttestationPool.java to handle committee bits
• Updated attestation filtering based on schema definitions for given slot
• Enhanced error handling for missing slot and empty attestations

_{3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

• Refactored waitForNonDefaultExecutionPayload in acceptance-tests/src/testFixtures/java/tech/pegasys/teku/test/acceptance/dsl/TekuBeaconNode.java
• Updated SyncCommitteeSubnetSubscription usage in beacon/validator/src/main/java/tech/pegasys/teku/validator/coordinator/ValidatorApiHandler.java
• Added getAttestationsAndMetaData method in data/provider/src/main/java/tech/pegasys/teku/api/NodeDataProvider.java
• Introduced PostSyncCommitteeData class in ethereum/json-types/src/main/java/tech/pegasys/teku/ethereum/json/types/validator/PostSyncCommitteeData.java
• Added support for Electra milestone in data/provider/src/main/java/tech/pegasys/teku/api/ValidatorDataProvider.java

_{37 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[tbenr]

LGTM

[greptile-apps]

PR Summary

(updates since last review)

This pull request introduces the GET/Attestation Pool API to retrieve attestations and metadata, enhancing the attestation retrieval process.

• acceptance-tests/src/acceptance-test/java/tech/pegasys/teku/test/acceptance/MergedGenesisAcceptanceTest.java: Updated genesisExecutionPayloadHeaderSource to use a lambda function for correct payload creation.
• data/provider/src/main/java/tech/pegasys/teku/api/DataProvider.java: Added recentChainData parameter to NodeDataProvider instantiation for accurate data retrieval.
• data/provider/src/main/java/tech/pegasys/teku/api/NodeDataProvider.java: Introduced RecentChainData dependency and getSlot method for improved attestation retrieval.
• validator/remote/src/main/java/tech/pegasys/teku/validator/remote/typedef/OkHttpValidatorMinimalTypeDefClient.java: Added functionality to retrieve Genesis data.
• validator/remote/src/integration-test/java/tech/pegasys/teku/validator/remote/typedef/handlers/GetGenesisRequestTest.java: Added integration tests for GetGenesisRequest to ensure correct handling of HTTP responses.

_{14 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}