Include meta data in BlockSelector result #5067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
commented
Mar 1, 2022
| import java.util.Objects; | ||
| import tech.pegasys.teku.spec.SpecMilestone; | ||
|
|
||
| public class ObjectAndMetaData<T> { |
There was a problem hiding this comment.
This class is more generic than we need right now but the next step is to add beacon state with metadata and we don't want to have two separate definitions of the metadata so introducing a class that can be shared now. Little bit of a YAGNI violation but I'm feeling lucky. :)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Update
BlockSelectorto return the requests block/blocks along with the metadata for those blocks (currently milestone and if optimistic sync affects the result).While currently the metadata is immediately discarded, this will allow us to gradually migrate the REST APIs that return block data to use the attached metadata instead of recalculating it in a way that may be inconsistent because of concurrent changes to the optimistic sync state or chain head.
Fixed Issue(s)
#4968
Documentation
documentationlabel to this PR if updates are required.Changelog