Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model3 control #2096

Closed
wants to merge 9 commits into from
Closed

Model3 control #2096

wants to merge 9 commits into from

Conversation

deltakosh
Copy link
Contributor

Issue: #2034

PR Type

What kind of change does this PR introduce? Feature

What is the current behavior?

None

What is the new behavior?

Introduce a new Model3D control to render glb files

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@nmetulev
Copy link
Contributor

Closing per feedback from community

@nmetulev nmetulev closed this May 15, 2018
@hansmbakker
Copy link
Contributor

hansmbakker commented Oct 20, 2018

@nmetulev Is there any update what will happen with this next? What was the feedback?

@nmetulev
Copy link
Contributor

It was decided not to include it in the toolkit per feedbck from the community :(

@hansmbakker
Copy link
Contributor

hansmbakker commented Oct 22, 2018

@nmetulev I didn't see any negative feedback here on GitHub, so I was surprised to read that.
Besides the question whether or not to include it in the toolkit, I asked what the feedback was to decide whether it was in a usable state and whether there were any shortcomings.
I'm looking for a 3d component to build a model visualization with, and wonder whether this component could serve that purpose (even outside the toolkit).

@deltakosh
Copy link
Contributor Author

@hansmbakker
Copy link
Contributor

hansmbakker commented Oct 22, 2018

@deltakosh thank you!

I saw that branch, too, but since @nmetulev said there was feedback I would like to know what the reasoning was - it would save people time knowing if there are any test results, limitations or known issues.

@nmetulev / @deltakosh besides the feedback question, how does the Model3d work relate to this API work discussed at Build 2018?

@deltakosh
Copy link
Contributor Author

The reasoning was that developers may not want to embed a webview to do the rendering but would have preferred a pure native solution (which seems to be the case in the video you linked).

I have to say I do not share that concern:)

@hansmbakker
Copy link
Contributor

Well, agreed that a native solution would eventually be preferable, but couldn't this be a semi-temporary solution for lack of a native solution? Now we have nothing, since the work in that video I linked is not released I believe.

If there would be a native solution eventually, couldn't that use a similar API for developers so that they could swap these controls?

@deltakosh
Copy link
Contributor Author

I would be all in for that;)

@hansmbakker
Copy link
Contributor

hansmbakker commented Oct 22, 2018

@nmetulev appreciating that you probably can't comment on the WIP that was presented at Build and whether there is any expected release date - what would you say about using this Model3d control as an in-place replacement until the native version is released?
So that we at least have something that can be used for visualization?

@nmetulev
Copy link
Contributor

What if this is released as source only so if anyone wants it they can use it, but won't ship as part of the nuget?

@hansmbakker
Copy link
Contributor

hansmbakker commented Oct 23, 2018

@nmetulev what would that mean? Is there any other part of the toolkit released that way, so that I can see an example?

Addition: how would that work for the toolkit demo app? I believe this branch has a demo included.

@nmetulev
Copy link
Contributor

We would only have the code as an example and not actually ship a binary - it would not be part of the sample app. No, there is no other part of the toolkit shipped that way yet, this would be first.

@GeorgeS2019
Copy link

In Build 2019 State of the Union - The Windows Presentation Platform - BRK3072 => it is stated that 3D Viewer Control is coming to WinUI 2.x
FYI: microsoft/microsoft-ui-xaml#686

@Kyaa-dost Kyaa-dost deleted the Model3D branch September 16, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants