-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model3 control #2096
Model3 control #2096
Conversation
Removed poop
Closing per feedback from community |
@nmetulev Is there any update what will happen with this next? What was the feedback? |
It was decided not to include it in the toolkit per feedbck from the community :( |
@nmetulev I didn't see any negative feedback here on GitHub, so I was surprised to read that. |
You can try it here if you want to evaluate it: https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/Model3D/Microsoft.Toolkit.Uwp.UI.Controls/Model3D |
@deltakosh thank you! I saw that branch, too, but since @nmetulev said there was feedback I would like to know what the reasoning was - it would save people time knowing if there are any test results, limitations or known issues. @nmetulev / @deltakosh besides the feedback question, how does the Model3d work relate to this API work discussed at Build 2018? |
The reasoning was that developers may not want to embed a webview to do the rendering but would have preferred a pure native solution (which seems to be the case in the video you linked). I have to say I do not share that concern:) |
Well, agreed that a native solution would eventually be preferable, but couldn't this be a semi-temporary solution for lack of a native solution? Now we have nothing, since the work in that video I linked is not released I believe. If there would be a native solution eventually, couldn't that use a similar API for developers so that they could swap these controls? |
I would be all in for that;) |
@nmetulev appreciating that you probably can't comment on the WIP that was presented at Build and whether there is any expected release date - what would you say about using this Model3d control as an in-place replacement until the native version is released? |
What if this is released as source only so if anyone wants it they can use it, but won't ship as part of the nuget? |
@nmetulev what would that mean? Is there any other part of the toolkit released that way, so that I can see an example? Addition: how would that work for the toolkit demo app? I believe this branch has a demo included. |
We would only have the code as an example and not actually ship a binary - it would not be part of the sample app. No, there is no other part of the toolkit shipped that way yet, this would be first. |
In Build 2019 State of the Union - The Windows Presentation Platform - BRK3072 => it is stated that 3D Viewer Control is coming to WinUI 2.x |
Issue: #2034
PR Type
What kind of change does this PR introduce? Feature
What is the current behavior?
None
What is the new behavior?
Introduce a new Model3D control to render glb files
PR Checklist