Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGrid RowDetails not changing theme at runtime #3305

Open
laracarbajal opened this issue May 27, 2020 · 5 comments · May be fixed by #4863
Open

DataGrid RowDetails not changing theme at runtime #3305

laracarbajal opened this issue May 27, 2020 · 5 comments · May be fixed by #4863
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior DataGrid 🔠 Issues on DataGrid control help wanted Issues identified as good community contribution opportunities In-PR 🚀
Milestone

Comments

@laracarbajal
Copy link

Describe the bug

DataGrid RowDetails not changing theme at runtime

Steps to Reproduce

Steps to reproduce the behavior:

  1. Just add a DataGrid to a project and set the RowDetailsVisibilityMode to VisibleWhenSelected in order to observe the issue.
  2. Add a button with a Click event to be able to change the app theme. RequestedTheme = ElementTheme.Dark or RequestedTheme = ElementTheme.Light will do the trick.
  3. As yo can see, the background of the RowDetail did not change.

Expected behavior

See some change according with the theme color.

Screenshots

Annotation 2020-05-27 134035

Annotation 2020-05-27 134238

Environment

NuGet Package(s):  
`Microsoft.Toolkit.Uwp.UI.Controls`
`Microsoft.Toolkit.Uwp.UI.Controls.DataGrid`

Package Version(s):  
6.0 (Both)

Windows 10 Build Number:
Windows 10, Version 1909, Build 18363.836

App min and target version:
- [ ] May 2019 Update (18362)


Device form factor:
Desktop

Visual Studio 
2019 (version: 16.5.5) 

Additional context

I've noticed some issues like TitleBar color not change even when I use var titleBar = ApplicationView.GetForCurrentView().TitleBar; and change the properties of it (I asked on Stack Overflow about that and some people can successfully change the titlebar color with my exact code). I do not know if that can be related.

@laracarbajal laracarbajal added the bug 🐛 An unexpected issue that highlights incorrect behavior label May 27, 2020
@ghost ghost added the needs triage 🔍 label May 27, 2020
@ghost
Copy link

ghost commented May 27, 2020

Hello JonasLara, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@Kyaa-dost Kyaa-dost added DataGrid 🔠 Issues on DataGrid control and removed needs triage 🔍 labels May 28, 2020
@Kyaa-dost
Copy link
Contributor

@anawishnoff @RBrid FYI ⬆️

@michael-hawker michael-hawker added this to the 7.0 milestone Jun 22, 2020
@michael-hawker michael-hawker added the help wanted Issues identified as good community contribution opportunities label Jun 22, 2020
@JulienTheron
Copy link

Hi. Is there any workaround for this issue?

@Kyaa-dost
Copy link
Contributor

@JulienTheron let's see if the Datagrid team knows of any workaround for this issue. @anawishnoff or @RBrid? ⬆️

@michael-hawker michael-hawker modified the milestones: 7.0, 7.1 Mar 9, 2021
@ghost
Copy link

ghost commented Jul 8, 2021

Thanks JonasLara for patiently waiting while the team is still investigating the issue.

@anawishnoff @RBrid can we please have an update on this issue? Thanks

@CommunityToolkit CommunityToolkit deleted a comment Aug 31, 2021
@CommunityToolkit CommunityToolkit deleted a comment Aug 31, 2021
@CommunityToolkit CommunityToolkit deleted a comment Aug 31, 2021
@michael-hawker michael-hawker modified the milestones: 7.1, 7.2/8.0? Aug 31, 2021
Zofware added a commit to Zofware/WindowsCommunityToolkit that referenced this issue Apr 3, 2023
@Zofware Zofware linked a pull request Apr 4, 2023 that will close this issue
4 tasks
@ghost ghost added the In-PR 🚀 label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior DataGrid 🔠 Issues on DataGrid control help wanted Issues identified as good community contribution opportunities In-PR 🚀
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants