Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for ISettingsStorageHelper in CommunityToolkit.Common v8 #4861

Open
3 of 14 tasks
LeftTwixWand opened this issue Mar 29, 2023 · 2 comments
Open
3 of 14 tasks
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior helpers ✋

Comments

@LeftTwixWand
Copy link

Describe the bug

ApplicationDataStorageHelper doesn't work with CommunityToolkit.Common v8. It refers to the ISettingsStorageHelper which was moved to the other namespace in v8:

Version 7: CommunityToolkit.Helpers.ISettingsStorageHelper

Version 8: CommunityToolkit.Common.Helpers.ISettingsStorageHelper

Maybe, it should be included to the v8 Release Plan: #4488

Regression

v7 of CommunityToolkit.Common

Reproducible in sample app?

  • This bug can be reproduced in the sample app.

Steps to reproduce

Add: CommunityToolkit.Common v8
Add: CommunityToolkit.WinUI v7

Run this code:

ApplicationDataStorageHelper applicationDataStorage = new(ApplicationData.Current);
applicationDataStorage.TryRead("MyKey", out string? text);

Expected behavior

I would like current WinUI (7) package version to support Common package with version 8

Screenshots

image

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

2022

Visual Studio Build Number

No response

Device form factor

Desktop

Nuget packages

CommunityToolkit.Common v8
CommunityToolkit.WinUI v7

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

@LeftTwixWand LeftTwixWand added the bug 🐛 An unexpected issue that highlights incorrect behavior label Mar 29, 2023
@ghost ghost added the needs triage 🔍 label Mar 29, 2023
@ghost
Copy link

ghost commented Mar 29, 2023

Hello LeftTwixWand, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@christopher-carmichael
Copy link

I just want to add I also have run into this issue. Simple fix was to downgrade to 7.1, but very annoying none the less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior helpers ✋
Projects
None yet
Development

No branches or pull requests

3 participants