Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of namespaces of public classes under Microsoft.Toolkit.Uwp.UI.Media #4124

Closed
ratishphilip opened this issue Jul 22, 2021 · 3 comments

Comments

@ratishphilip
Copy link
Contributor

Several classes under the Microsoft.Toolkit.Uwp.UI.Media project have their namespaces based on their folder location within the project.

I would recommend renaming the namespaces to Microsoft.Toolkit.Uwp.UI.Media. We can target this for 8.0 release.

@michael-hawker

@ghost ghost added the needs triage 🔍 label Jul 22, 2021
@ghost
Copy link

ghost commented Jul 22, 2021

Hello ratishphilip, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@michael-hawker
Copy link
Member

FYI @Sergio0694

@Sergio0694
Copy link
Member

Sounds like a good idea for 8.0, to follow what we did in #3422.
We can definitely take a look once #3442 is merged 😄

Note: I don't think we should just place everything in Microsoft.Toolkit.Uwp.UI.Media and it might still make sense to keep some nested namespaces in some cases, but we can definitely look into reducing the coupling and simplifying things a bit 👍

@CommunityToolkit CommunityToolkit locked and limited conversation to collaborators Aug 2, 2022
@LalithaNadimpalli LalithaNadimpalli converted this issue into discussion #4709 Aug 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

3 participants