Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Star Rail BiliBili - Dispatch Server Channel Incorrect #550

Closed
studiobutter opened this issue Aug 1, 2024 · 5 comments
Closed

[Bug]: Star Rail BiliBili - Dispatch Server Channel Incorrect #550

studiobutter opened this issue Aug 1, 2024 · 5 comments
Assignees
Labels
Area: Dispatcher Key Issue labeled for Dispatcher Key/API Token related issue Area: Mirror/API Server Issue labeled for Mirror/API Server issue releated Area: Preset Config Issue labeled for Preset/Region Configuration Fixed Issue has been fixed Game: Honkai: Star Rail Issue labeled for Honkai: Star Rail

Comments

@studiobutter
Copy link

Affected Version

1.80.17 (REL) - 1.81.0 (PRE) - 1.81.0d (DBG)

Bug Behavior

Repair Function isn't working correctly for HSR - BiliBili Server.
Stable and Preview behavior: Repair Function somehow fall back to Star Rail - Global Repair Data on BiliBili Server. Cache Update Function Errors
Debug: Repair and Cache Update Functions display error

VS Debug: Collapse Repair and Cache Update function for Star Rail - BiliBili was using the Dispatch URL with the wrong channel and sub_channel ids.

Expected Behavior

Repair and Cache Update Function should be using the correct metadata.

Debug: By using the correct channel and sub_channel ids

Steps to reproduce

Do a repair on Star Rail - BiliBili.

If on Debug, Console should give out all the dispatch correctly with the Dispatch URL using the correct URL and it's JSON prefixes

Related Issues

No response

Screenshot(s)

No response

Additional Information

Debug Log

@studiobutter studiobutter added the Needs Triaging This issue needs the developer's attention to sort & prioritize. label Aug 1, 2024
@neon-nyan neon-nyan added Bug Something isn't working Area: Preset Config Issue labeled for Preset/Region Configuration Game: Honkai: Star Rail Issue labeled for Honkai: Star Rail Area: Mirror/API Server Issue labeled for Mirror/API Server issue releated Area: Dispatcher Key Issue labeled for Dispatcher Key/API Token related issue labels Aug 1, 2024
@neon-nyan neon-nyan self-assigned this Aug 1, 2024
@neon-nyan
Copy link
Member

Update - 2024/08/03

The fix for this issue has been fixed alongside this change: 93cd7d3...39b863d
For the current stable/preview version, the fix has already been pushed via metadata update.

Can you confirm if the issue is fixed?

@studiobutter
Copy link
Author

The repair function seems to be working correctly with the only issue being the necessary "unused" files for Cutscenes problem that all regions having.
image

Otherwise, it's working as intended.

@neon-nyan
Copy link
Member

neon-nyan commented Aug 2, 2024

Fixed the files incorrectly being detected as "Unused" 39b863d...bb3807c

The part of the code should've been removed as the behavior with the in-game update has been changed since v2.2

@bagusnl
Copy link
Member

bagusnl commented Aug 2, 2024

Note:
Changes needed to fix this can't be (easily) back ported to stable. Either:

  1. Notify HSR: Bilibili user to move to preview
  2. Back port (by cherry picking) all necessary metadata changes to stable

@Cryotechnic Cryotechnic added Fixed Issue has been fixed and removed Needs Triaging This issue needs the developer's attention to sort & prioritize. Bug Something isn't working labels Aug 18, 2024
@Cryotechnic
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Dispatcher Key Issue labeled for Dispatcher Key/API Token related issue Area: Mirror/API Server Issue labeled for Mirror/API Server issue releated Area: Preset Config Issue labeled for Preset/Region Configuration Fixed Issue has been fixed Game: Honkai: Star Rail Issue labeled for Honkai: Star Rail
Projects
None yet
Development

No branches or pull requests

4 participants